From 9d96959ddec9c4b74ca1d0731568a6095c13af42 Mon Sep 17 00:00:00 2001 From: Vivia Nikolaidou Date: Tue, 12 Apr 2016 16:25:12 +0300 Subject: [PATCH] decodebin: Rename misleading variable is_parser_converter into is_parser In that place, the variable isn't checking whether the element is a converter, only if it is a parser. https://bugzilla.gnome.org/show_bug.cgi?id=764948 --- gst/playback/gstdecodebin2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gst/playback/gstdecodebin2.c b/gst/playback/gstdecodebin2.c index 110ad44..fc35ac6 100644 --- a/gst/playback/gstdecodebin2.c +++ b/gst/playback/gstdecodebin2.c @@ -2132,7 +2132,7 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad, gboolean subtitle; GList *to_connect = NULL; GList *to_expose = NULL; - gboolean is_parser_converter = FALSE; + gboolean is_parser = FALSE; /* Set dpad target to pad again, it might've been unset * below but we came back here because something failed @@ -2198,10 +2198,10 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad, * parser is the only one that does not change the data. A * valid example for this would be multiple id3demux in a row. */ - is_parser_converter = strstr (gst_element_factory_get_metadata (factory, + is_parser = strstr (gst_element_factory_get_metadata (factory, GST_ELEMENT_METADATA_KLASS), "Parser") != NULL; - if (is_parser_converter) { + if (is_parser) { gboolean skip = FALSE; GList *l; -- 2.7.4