From 9d8c829c2f8a4ea06af8ab77ae2988280744cbf8 Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Mon, 8 Aug 2016 16:55:19 +0900 Subject: [PATCH] elm app client - check return of eldbus_message_iter_arguments_get as accoding to coverity CID 1353593 chekc returns of the above function and return/continue as apporpriate if these fail (which generallly they shouldnt unless some end of the dbus client is broken). --- src/lib/elementary/elm_app_client.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lib/elementary/elm_app_client.c b/src/lib/elementary/elm_app_client.c index fcdee64..b3884ea 100644 --- a/src/lib/elementary/elm_app_client.c +++ b/src/lib/elementary/elm_app_client.c @@ -21,15 +21,17 @@ _sub_path_process(Elm_App_Client *eo, Eldbus_Message_Iter *obj_iter, Elm_App_Cli const char *obj_path; Eldbus_Message_Iter *array_iface, *iface; - eldbus_message_iter_arguments_get(obj_iter, "oa{sa{sv}}", &obj_path, &array_iface); + if (!eldbus_message_iter_arguments_get(obj_iter, "oa{sa{sv}}", &obj_path, &array_iface)) + return; while (eldbus_message_iter_get_and_next(array_iface, '{', &iface)) { const char *iface_name; Eldbus_Message_Iter *array_props; Elm_App_Client_View *view; - eldbus_message_iter_arguments_get(iface, "sa{sv}", &iface_name, - &array_props); + if (!eldbus_message_iter_arguments_get(iface, "sa{sv}", &iface_name, + &array_props)) + continue; if (strcmp(iface_name, "org.enlightenment.ApplicationView1")) continue; -- 2.7.4