From 9c6a2583f115acf29a27709ca9ce37714d04fb24 Mon Sep 17 00:00:00 2001 From: Nathan Chancellor Date: Thu, 31 Jan 2019 11:06:28 -0700 Subject: [PATCH] serial: mps2-uart: Add parentheses around conditional in mps2_uart_shutdown Clang warns: drivers/tty/serial/mps2-uart.c:351:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ~ drivers/tty/serial/mps2-uart.c:351:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ( ) drivers/tty/serial/mps2-uart.c:351:6: note: add parentheses around left hand side expression to silence this warning if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ( ) 1 warning generated. As it was intended for this check to be the inverse of the one at the bottom of mps2_init_port, add parentheses around the whole conditional. Fixes: 775ea4ea2fd9 ("serial: mps2-uart: support combined irq") Signed-off-by: Nathan Chancellor Acked-by: Vladimir Murzin Link: https://github.com/ClangBuiltLinux/linux/issues/344 Reviewed-by: Nick Desaulniers Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/mps2-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mps2-uart.c b/drivers/tty/serial/mps2-uart.c index 4404eb7..587b42f 100644 --- a/drivers/tty/serial/mps2-uart.c +++ b/drivers/tty/serial/mps2-uart.c @@ -348,7 +348,7 @@ static void mps2_uart_shutdown(struct uart_port *port) mps2_uart_write8(port, control, UARTn_CTRL); - if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { + if (!(mps_port->flags & UART_PORT_COMBINED_IRQ)) { free_irq(mps_port->rx_irq, mps_port); free_irq(mps_port->tx_irq, mps_port); } -- 2.7.4