From 9c59d2f16ad37dfc0a8b85a06cf4c117ebf5a690 Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Mon, 21 Sep 2015 17:20:39 +0200 Subject: [PATCH] doc: remove extra using v8::HandleScope statement v8::HandleScope does not seem to be required for addon functions. PR-URL: https://github.com/nodejs/node/pull/2983 Reviewed-By: Ben Noordhuis --- doc/api/addons.markdown | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/doc/api/addons.markdown b/doc/api/addons.markdown index 2ed289b..61fdc2d 100644 --- a/doc/api/addons.markdown +++ b/doc/api/addons.markdown @@ -44,7 +44,6 @@ First we create a file `hello.cc`: namespace demo { using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Object; @@ -155,7 +154,6 @@ function calls and return a result. This is the main and only needed source using v8::Exception; using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Number; @@ -212,7 +210,6 @@ there. Here's `addon.cc`: using v8::Function; using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Null; @@ -263,7 +260,6 @@ the string passed to `createObject()`: namespace demo { using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Object; @@ -310,7 +306,6 @@ wraps a C++ function: using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Object; @@ -415,7 +410,6 @@ prototype: using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Number; @@ -505,7 +499,6 @@ Let's register our `createObject` method in `addon.cc`: namespace demo { using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Object; @@ -568,7 +561,6 @@ The implementation is similar to the above in `myobject.cc`: using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Number; @@ -668,7 +660,6 @@ In the following `addon.cc` we introduce a function `add()` that can take on two namespace demo { using v8::FunctionCallbackInfo; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Number; @@ -745,7 +736,6 @@ The implementation of `myobject.cc` is similar as before: using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; - using v8::HandleScope; using v8::Isolate; using v8::Local; using v8::Object; -- 2.7.4