From 9b914aacbd5414e48fa2a58e0082e7b69c783278 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 8 Dec 2021 11:43:43 +0100 Subject: [PATCH] [llvm] Remove out-of-date fixme from SmallVectorMemoryBuffer This fixme first appeared in the codebase with the introduction of `ObjectMemoryBuffer` in rG93de2a12a36feaf1e6d8ff28c76db9b6cda4e844, but the constructor appears to never have been templated. Reviewed By: dexonsmith Differential Revision: https://reviews.llvm.org/D115044 --- llvm/include/llvm/Support/SmallVectorMemoryBuffer.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h b/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h index 9aa4e9a..af748cf 100644 --- a/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h +++ b/llvm/include/llvm/Support/SmallVectorMemoryBuffer.h @@ -30,12 +30,6 @@ class SmallVectorMemoryBuffer : public MemoryBuffer { public: /// Construct an SmallVectorMemoryBuffer from the given SmallVector /// r-value. - /// - /// FIXME: It'd be nice for this to be a non-templated constructor taking a - /// SmallVectorImpl here instead of a templated one taking a SmallVector, - /// but SmallVector's move-construction/assignment currently only take - /// SmallVectors. If/when that is fixed we can simplify this constructor and - /// the following one. SmallVectorMemoryBuffer(SmallVectorImpl &&SV) : SV(std::move(SV)), BufferName("") { init(this->SV.begin(), this->SV.end(), false); -- 2.7.4