From 9b4650e9038b1c1c15c132f46455da3f8b7a2295 Mon Sep 17 00:00:00 2001 From: "dcarney@chromium.org" Date: Wed, 13 Mar 2013 13:14:25 +0000 Subject: [PATCH] remove maynamedaccess checks R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/12822002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/isolate.cc | 6 +----- src/objects.cc | 2 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/isolate.cc b/src/isolate.cc index 5f7b3f2..4192d11 100644 --- a/src/isolate.cc +++ b/src/isolate.cc @@ -944,11 +944,7 @@ bool Isolate::MayNamedAccess(JSObject* receiver, Object* key, if (decision != UNKNOWN) return decision == YES; // Get named access check callback - // TODO(dcarney): revert - Map* map = receiver->map(); - CHECK(map->IsMap()); - CHECK(map->constructor()->IsJSFunction()); - JSFunction* constructor = JSFunction::cast(map->constructor()); + JSFunction* constructor = JSFunction::cast(receiver->map()->constructor()); if (!constructor->shared()->IsApiFunction()) return false; Object* data_obj = diff --git a/src/objects.cc b/src/objects.cc index 7559083..3de981c 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -768,8 +768,6 @@ MaybeObject* Object::GetProperty(Object* receiver, // that even though we may not actually end up loading the named // property from the current object, we still check that we have // access to it. - // TODO(dcarney): revert. - CHECK(current->IsJSObject()); JSObject* checked = JSObject::cast(current); if (!heap->isolate()->MayNamedAccess(checked, name, v8::ACCESS_GET)) { return checked->GetPropertyWithFailedAccessCheck(receiver, -- 2.7.4