From 9b2283cc3352b1f446814f0c6fa5230978b9ee78 Mon Sep 17 00:00:00 2001 From: Stefan Huehner Date: Thu, 9 Feb 2006 14:08:03 +0000 Subject: [PATCH] Patch by Stefan Huehner / stefan % huehner ! org \ MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit patch replaces '()' for the correct '(void)' in function declarations/prototypes which have no parameters. The '()' syntax tell thats there is a variable list of arguments, so that the compiler cannot check this. The extra CFLAG '-Wstrict-declarations' shows those cases. Comments about a similar patch applied to ffmpeg: That in C++ these mean the same, but in ANSI C the semantics are different; function() is an (obsolete) K&R C style forward declaration, it basically means that the function can have any number and any types of parameters, effectively completely preventing the compiler from doing any sort of type checking. -- Erik Slagter Defining functions with unspecified arguments is allowed but bad. With arguments unspecified the compiler can't report an error/warning if the function is called with incorrect arguments. -- Måns Rullgård Originally committed as revision 17567 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc --- postproc/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/postproc/swscale.c b/postproc/swscale.c index 2b0d585..e4537f7 100644 --- a/postproc/swscale.c +++ b/postproc/swscale.c @@ -1375,7 +1375,7 @@ static void initMMX2HScaler(int dstW, int xInc, uint8_t *funnyCode, int16_t *fil } #endif // ARCH_X86 || ARCH_X86_64 -static void globalInit(){ +static void globalInit(void){ // generating tables: int i; for(i=0; i<768; i++){ -- 2.7.4