From 9b21516fe496ae646210c6a6ceac0347b36d5811 Mon Sep 17 00:00:00 2001 From: Dave Stevenson Date: Mon, 3 Oct 2022 14:21:35 +0100 Subject: [PATCH] vc04_services: bcm2835-codec: Remove redundant role check vidioc_try_encoder_cmd checks the role, but the ioctl is disabled for any roles in which it is invalid. Remove the redundant check. Signed-off-by: Dave Stevenson --- drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c b/drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c index ca063a2..be70be1 100644 --- a/drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c +++ b/drivers/staging/vc04_services/bcm2835-codec/bcm2835-v4l2-codec.c @@ -2463,9 +2463,6 @@ static int vidioc_try_encoder_cmd(struct file *file, void *priv, { struct bcm2835_codec_ctx *ctx = file2ctx(file); - if (ctx->dev->role != ENCODE && ctx->dev->role != ENCODE_IMAGE) - return -EINVAL; - switch (cmd->cmd) { case V4L2_ENC_CMD_STOP: break; -- 2.7.4