From 9b16c624edde50e2a460f9bd0d2e9ac3cb1af695 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Wed, 11 Jan 2023 18:03:58 +0100 Subject: [PATCH] [clangd] Respect clang-tidy SystemHeaders option if specified (Previous commit assumed it was always off, which is the default) --- clang-tools-extra/clangd/ParsedAST.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/clangd/ParsedAST.cpp b/clang-tools-extra/clangd/ParsedAST.cpp index 637cada..d10da8c 100644 --- a/clang-tools-extra/clangd/ParsedAST.cpp +++ b/clang-tools-extra/clangd/ParsedAST.cpp @@ -542,8 +542,8 @@ ParsedAST::build(llvm::StringRef Filename, const ParseInputs &Inputs, // NOLINT comments)? return DiagnosticsEngine::Ignored; } - // Match behavior for clang-tidy --system-headers=0 (the default). - if (Info.hasSourceManager() && + if (!CTContext->getOptions().SystemHeaders.value_or(false) && + Info.hasSourceManager() && Info.getSourceManager().isInSystemMacro(Info.getLocation())) return DiagnosticsEngine::Ignored; -- 2.7.4