From 9ac75d1f06d0bdbd7b4b3cecadc2e2d651779d9f Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 26 Aug 2013 15:13:35 +0200 Subject: [PATCH] src: remove pointless node_os.h header file src/node_os.cc doesn't export anything that's used elsewhere. Remove it. --- node.gyp | 1 - src/node_os.cc | 10 +++++----- src/node_os.h | 37 ------------------------------------- 3 files changed, 5 insertions(+), 43 deletions(-) delete mode 100644 src/node_os.h diff --git a/node.gyp b/node.gyp index f42ba46..ebf7ebd 100644 --- a/node.gyp +++ b/node.gyp @@ -125,7 +125,6 @@ 'src/node_file.h', 'src/node_http_parser.h', 'src/node_javascript.h', - 'src/node_os.h', 'src/node_root_certs.h', 'src/node_version.h', 'src/node_watchdog.h', diff --git a/src/node_os.cc b/src/node_os.cc index 4e79127..36506fc 100644 --- a/src/node_os.cc +++ b/src/node_os.cc @@ -21,8 +21,6 @@ #include "node.h" -#include "node_os.h" - #include "v8.h" #include @@ -45,9 +43,11 @@ #endif // MAXHOSTNAMELEN namespace node { +namespace os { using v8::Array; using v8::FunctionCallbackInfo; +using v8::Handle; using v8::HandleScope; using v8::Local; using v8::Number; @@ -275,7 +275,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo& args) { } -void OS::Initialize(v8::Handle target) { +void Initialize(Handle target) { HandleScope scope(node_isolate); NODE_SET_METHOD(target, "getEndianness", GetEndianness); @@ -290,7 +290,7 @@ void OS::Initialize(v8::Handle target) { NODE_SET_METHOD(target, "getInterfaceAddresses", GetInterfaceAddresses); } - +} // namespace os } // namespace node -NODE_MODULE(node_os, node::OS::Initialize) +NODE_MODULE(node_os, node::os::Initialize) diff --git a/src/node_os.h b/src/node_os.h deleted file mode 100644 index f496863..0000000 --- a/src/node_os.h +++ /dev/null @@ -1,37 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -#ifndef SRC_NODE_OS_H_ -#define SRC_NODE_OS_H_ - -#include "node.h" -#include "v8.h" - -namespace node { - -class OS { - public: - static void Initialize(v8::Handle target); -}; - -} // namespace node - -#endif // SRC_NODE_OS_H_ -- 2.7.4