From 9a9dce8e42c0ff4fa4cca9d97c2db31fcb377b17 Mon Sep 17 00:00:00 2001 From: Russ Keldorph Date: Mon, 6 Feb 2017 14:19:21 -0800 Subject: [PATCH] Default-trigger ARM64 testing on certain users PRs Re-using the logic that allows certain users to request ARM64 testing to default-trigger ARM64 testing on their PRs. Ideally, we'd be able to separate the list of people who have permission to trigger testing from those that get testing by default, but that is harder than it seems. --- netci.groovy | 38 +++++++++++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/netci.groovy b/netci.groovy index c3521b4d56..8683028008 100755 --- a/netci.groovy +++ b/netci.groovy @@ -1186,13 +1186,45 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os, contextString += " and Test" } - def arm64Users = ['erozenfeld', 'kyulee1', 'pgavlin', 'russellhadley', 'swaroop-sridhar', 'JosephTremoulet', 'jashook', 'RussKeldorph', 'gkhanna79', 'briansull', 'cmckinsey', 'jkotas', 'ramarag', 'markwilkie', 'rahku', 'tzwlai', 'weshaggard'] + def arm64Users = [ + 'adiaaida', + 'AndyAyersMS', + 'briansull', + 'BruceForstall', + 'CarolEidt', + 'cmckinsey', + 'erozenfeld', + 'jashook', + 'JosephTremoulet', + 'pgavlin', + 'pkukol', + 'russellhadley', + 'RussKeldorph', + 'sandreenko', + 'sivarv', + 'swaroop-sridhar', + 'gkhanna79', + 'jkotas', + 'markwilkie', + 'rahku', + 'ramarag', + 'tzwlai', + 'weshaggard' + ] + switch (os) { case 'Windows_NT': switch (scenario) { case 'default': - Utilities.addPrivateGithubPRTriggerForBranch(job, branch, contextString, - "(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}.*", null, arm64Users) + if (configuration == 'Release') { + Utilities.addPrivateGithubPRTriggerForBranch(job, branch, contextString, + "(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}.*", null, arm64Users) + } + else { + // Add "Checked Build And Test" and "Debug Build" to the above users' PRs since many of them + // are at higher risk of ARM64-breaking changes. + Utilities.addDefaultPrivateGithubPRTriggerForBranch(job, branch, contextString, null, arm64Users) + } break case 'pri1r2r': case 'gcstress0x3': -- 2.34.1