From 9a7c6ae32cdd0e7ab2c02f53256c7f6d07763f8b Mon Sep 17 00:00:00 2001 From: Paulo Zanoni Date: Tue, 8 Aug 2023 17:14:49 -0700 Subject: [PATCH] anv/xe: return failure in case waiting for the vm_bind syncobj fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Don't hide failures, we have xe.ko bugs related to that, such as: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/496 The bind ioctl may fail if the application does something wrong, but the wait really should never fail. v2: Don't print an error message (Lionel). Reviewed-by: José Roberto de Souza (v1) Reviewed-by: Lionel Landwerlin Signed-off-by: Paulo Zanoni Part-of: --- src/intel/vulkan/xe/anv_kmd_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/xe/anv_kmd_backend.c b/src/intel/vulkan/xe/anv_kmd_backend.c index 09a1433..f1dd1d5 100644 --- a/src/intel/vulkan/xe/anv_kmd_backend.c +++ b/src/intel/vulkan/xe/anv_kmd_backend.c @@ -176,7 +176,7 @@ xe_vm_bind_op(struct anv_device *device, int num_binds, .first_signaled = 0, .pad = 0, }; - intel_ioctl(device->fd, DRM_IOCTL_SYNCOBJ_WAIT, &wait); + ret = intel_ioctl(device->fd, DRM_IOCTL_SYNCOBJ_WAIT, &wait); bind_error: STACK_ARRAY_FINISH(xe_binds_stackarray); -- 2.7.4