From 9a412d13c14ec27bb99354bebf9a71f74bde2330 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Thu, 24 Jul 2014 19:53:33 +0000 Subject: [PATCH] Replace an assertion with a fatal error Frontends are responsible for putting inalloca on parameters that would be passed in memory and not registers. llvm-svn: 213891 --- llvm/lib/Target/X86/X86ISelLowering.cpp | 8 ++++++-- llvm/test/CodeGen/X86/inalloca-regparm.ll | 15 +++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 llvm/test/CodeGen/X86/inalloca-regparm.ll diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 6a01044..c0a735b 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -2680,8 +2680,12 @@ X86TargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI, // arguments passed in memory when using inalloca. if (!Outs.empty() && Outs.back().Flags.isInAlloca()) { NumBytesToPush = 0; - assert(ArgLocs.back().getLocMemOffset() == 0 && - "an inalloca argument must be the only memory argument"); + if (!ArgLocs.back().isMemLoc()) + report_fatal_error("cannot use inalloca attribute on a register " + "parameter"); + if (ArgLocs.back().getLocMemOffset() != 0) + report_fatal_error("any parameter with the inalloca attribute must be " + "the only memory argument"); } if (!IsSibcall) diff --git a/llvm/test/CodeGen/X86/inalloca-regparm.ll b/llvm/test/CodeGen/X86/inalloca-regparm.ll new file mode 100644 index 0000000..9dd916b --- /dev/null +++ b/llvm/test/CodeGen/X86/inalloca-regparm.ll @@ -0,0 +1,15 @@ +; RUN: llc -mtriple=i686-windows-msvc < %s -o /dev/null +; RUN: not llc -mtriple=x86_64-windows-msvc %s -o /dev/null 2>&1 | FileCheck %s + +; This will compile successfully on x86 but not x86_64, because %b will become a +; register parameter. + +declare x86_thiscallcc i32 @f(i32 %a, i32* inalloca %b) +define void @g() { + %b = alloca inalloca i32 + store i32 2, i32* %b + call x86_thiscallcc i32 @f(i32 0, i32* inalloca %b) + ret void +} + +; CHECK: cannot use inalloca attribute on a register parameter -- 2.7.4