From 9a31b01486a267689bb820079206c72e1ec6de53 Mon Sep 17 00:00:00 2001 From: Jose Quaresma Date: Sun, 14 Jun 2020 16:34:50 +0100 Subject: [PATCH] overrides: fix memory leak in pyg_boxed_new pyg_boxed_new cause a memory leak if it hold a copy of the boxed wrapper and freed when the wrapper is deallocated. use the boxed wrapper value itself and don't hold a copy of the value. --- gi/overrides/gstmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gi/overrides/gstmodule.c b/gi/overrides/gstmodule.c index ef2eb45..0fc7bfe 100644 --- a/gi/overrides/gstmodule.c +++ b/gi/overrides/gstmodule.c @@ -736,7 +736,7 @@ _remap (GstMapInfo * mapinfo, PyObject * py_mapinfo) PyMemoryView_FromMemory ((char *) mapinfo->data, mapinfo->size, flags); /* Box GstMemory into a Gst.Memory */ - py_memory = pyg_boxed_new (_gst_memory_type, mapinfo->memory, TRUE, TRUE); + py_memory = pyg_boxed_new (_gst_memory_type, mapinfo->memory, FALSE, FALSE); /* Fill out Gst.MapInfo with values corresponding to GstMapInfo */ if (PyObject_SetAttrString (py_mapinfo, "memory", py_memory) == -1) return NULL; -- 2.7.4