From 9a2565863f424dc9ee3322ad87befdbf1d71b93a Mon Sep 17 00:00:00 2001 From: Bruce Forstall Date: Thu, 30 Nov 2017 13:58:08 -0800 Subject: [PATCH] Don't add triggers for arm/armlb/arm64 non-flow jobs --- netci.groovy | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/netci.groovy b/netci.groovy index 1acb5d2..68d9a2e 100755 --- a/netci.groovy +++ b/netci.groovy @@ -1166,6 +1166,11 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os, } break case 'Windows_NT': + // Triggers on the non-flow jobs aren't necessary here + if (!isFlowJob) { + break + } + // Set up a private trigger def contextString = "${os} ${architecture} Cross ${configuration}" def triggerString = "(?i).*test\\W+${os}\\W+${architecture}\\W+Cross\\W+${configuration}" @@ -1262,6 +1267,11 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os, } break case 'Windows_NT': + // Triggers on the non-flow jobs aren't necessary here + if (!isFlowJob) { + break + } + assert isArmWindowsScenario(scenario) switch (scenario) { case 'default': @@ -1828,8 +1838,6 @@ def static calculateBuildCommands(def newJob, def scenario, def branch, def isPR return buildCommands } -// Additional scenario which can alter behavior - Constants.allScenarios.each { scenario -> [true, false].each { isPR -> Constants.architectureList.each { architecture -> @@ -2059,7 +2067,7 @@ Constants.allScenarios.each { scenario -> // Add all the standard options Utilities.standardJobSetup(newJob, project, isPR, "*/${branch}") - addTriggers(newJob, branch, isPR, architecture, os, configuration, scenario, false, isBuildOnly) + addTriggers(newJob, branch, isPR, architecture, os, configuration, scenario, false, isBuildOnly) // isFlowJob==false def buildCommands = calculateBuildCommands(newJob, scenario, branch, isPR, architecture, configuration, os, isBuildOnly) def osGroup = getOSGroup(os) @@ -2741,7 +2749,7 @@ build(params + [CORECLR_BUILD: coreclrBuildJob.build.number, setMachineAffinity(newFlowJob, os, flowArch, affinityOptions) Utilities.standardJobSetup(newFlowJob, project, isPR, "*/${branch}") - addTriggers(newFlowJob, branch, isPR, architecture, os, configuration, scenario, true, false) + addTriggers(newFlowJob, branch, isPR, architecture, os, configuration, scenario, true, false) // isFlowJob==true, isWindowsBuildOnlyJob==false } // configuration } // os } // architecture -- 2.7.4