From 99e64623ec9b31def9375753491cc6093c831809 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Thu, 5 Nov 2020 12:10:38 -0800 Subject: [PATCH] Do not construct std::string from nullptr While I am trying to forbid such usages systematically in https://reviews.llvm.org/D79427 / P2166R0 to C++ standard, this PR fixes this (definitelly incorrect) usage in llvm. This code is unreachable, so it could not cause any harm Reviewed By: nikic, dblaikie Differential Revision: https://reviews.llvm.org/D87697 --- llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp index da1a398..38844ff 100644 --- a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp @@ -1272,9 +1272,6 @@ void NVPTXAsmPrinter::emitPTXAddressSpace(unsigned int AddressSpace, std::string NVPTXAsmPrinter::getPTXFundamentalTypeStr(Type *Ty, bool useB4PTR) const { switch (Ty->getTypeID()) { - default: - llvm_unreachable("unexpected type"); - break; case Type::IntegerTyID: { unsigned NumBits = cast(Ty)->getBitWidth(); if (NumBits == 1) @@ -1305,9 +1302,10 @@ NVPTXAsmPrinter::getPTXFundamentalTypeStr(Type *Ty, bool useB4PTR) const { return "b32"; else return "u32"; + default: + break; } llvm_unreachable("unexpected type"); - return nullptr; } void NVPTXAsmPrinter::emitPTXGlobalVariable(const GlobalVariable *GVar, -- 2.7.4