From 99e18ef82316015bf717086bd0a17aa28a7b173b Mon Sep 17 00:00:00 2001 From: Panu Matilainen Date: Wed, 5 Oct 2011 13:58:33 +0300 Subject: [PATCH] Eliminate pointless exit label from headerVerify() - pgpNewDig() like most rpm "constructor" functions cannot fail, no point checking the result. Allows an icky backwards goto + label to be eliminated. --- lib/package.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/package.c b/lib/package.c index b338e9b..e74157b 100644 --- a/lib/package.c +++ b/lib/package.c @@ -351,7 +351,6 @@ exit: /* If no header-only digest/signature, then do simple sanity check. */ if (info.tag == 0) { -verifyinfo_exit: xx = headerVerifyInfo(ril-1, dl, pe+1, &entry.info, 0); if (xx != -1) { rasprintf(&buf, @@ -372,8 +371,6 @@ verifyinfo_exit: /* Verify header-only digest/signature. */ dig = pgpNewDig(); - if (dig == NULL) - goto verifyinfo_exit; sigtd.tag = info.tag; sigtd.type = info.type; -- 2.7.4