From 99d3fce3c749dfc0a8ab54da231c3379ee674d87 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Mon, 20 Mar 2017 13:01:28 -0700 Subject: [PATCH] node::Environment should be destroyed before AtomBindings The shutdown code may still uses the APIs provieded by AtomBindings. --- atom/browser/atom_browser_main_parts.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atom/browser/atom_browser_main_parts.h b/atom/browser/atom_browser_main_parts.h index 71adc43d5..2ba7d341f 100644 --- a/atom/browser/atom_browser_main_parts.h +++ b/atom/browser/atom_browser_main_parts.h @@ -80,9 +80,9 @@ class AtomBrowserMainParts : public brightray::BrowserMainParts { std::unique_ptr browser_; std::unique_ptr js_env_; - std::unique_ptr node_env_; std::unique_ptr node_bindings_; std::unique_ptr atom_bindings_; + std::unique_ptr node_env_; std::unique_ptr node_debugger_; base::Timer gc_timer_; -- 2.34.1