From 99a58e36ad76ec2cce4c4d917086ec4c95723b9d Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Mon, 25 Jun 2012 13:28:11 +0000 Subject: [PATCH] Correctly throw reference error in strict mode with ICs disabled. R=jkummerow@chromium.org BUG=v8:2119 TEST=regress/regress-2119.js Review URL: https://chromiumcodereview.appspot.com/10659011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/ic.cc | 7 ++++--- test/mjsunit/regress/regress-2119.js | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+), 3 deletions(-) create mode 100644 test/mjsunit/regress/regress-2119.js diff --git a/src/ic.cc b/src/ic.cc index f080bed..1f0070b 100644 --- a/src/ic.cc +++ b/src/ic.cc @@ -1385,12 +1385,13 @@ MaybeObject* StoreIC::Store(State state, } // Lookup the property locally in the receiver. - if (FLAG_use_ic && !receiver->IsJSGlobalProxy()) { + if (!receiver->IsJSGlobalProxy()) { LookupResult lookup(isolate()); if (LookupForWrite(receiver, name, &lookup)) { - // Generate a stub for this store. - UpdateCaches(&lookup, state, strict_mode, receiver, name, value); + if (FLAG_use_ic) { // Generate a stub for this store. + UpdateCaches(&lookup, state, strict_mode, receiver, name, value); + } } else { // Strict mode doesn't allow setting non-existent global property // or an assignment to a read only property. diff --git a/test/mjsunit/regress/regress-2119.js b/test/mjsunit/regress/regress-2119.js new file mode 100644 index 0000000..54840c2 --- /dev/null +++ b/test/mjsunit/regress/regress-2119.js @@ -0,0 +1,36 @@ +// Copyright 2012 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --nouse-ic + +function strict_function() { + "use strict" + undeclared = 1; +} + +assertThrows(strict_function); + -- 2.7.4