From 9987997c75a87e9ad56e65d1ad0f5ea624f2e012 Mon Sep 17 00:00:00 2001 From: Seunghun Lee Date: Fri, 14 Mar 2025 19:29:30 +0900 Subject: [PATCH] e_comp_wl_rsm: Fix unreachable code Change-Id: Idcbb8af526ce5f918934227b4ea0b0e1bdbf0469 --- src/bin/server/e_comp_wl_rsm.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/bin/server/e_comp_wl_rsm.c b/src/bin/server/e_comp_wl_rsm.c index e2c0079d2d..cdb586284f 100644 --- a/src/bin/server/e_comp_wl_rsm.c +++ b/src/bin/server/e_comp_wl_rsm.c @@ -3122,7 +3122,7 @@ _e_comp_wl_remote_surface_state_commit(E_Client *ec, E_Comp_Wl_Surface_State *st } } -static Eina_Bool +static void _e_comp_wl_remote_surface_subsurface_commit(E_Comp_Wl_Remote_Provider *parent_provider, E_Client *ec) { @@ -3138,15 +3138,15 @@ _e_comp_wl_remote_surface_subsurface_commit(E_Comp_Wl_Remote_Provider *parent_pr e_comp_wl_surface_commit(ec); buffer = e_pixmap_resource_get(ec->pixmap); - if (!buffer) return EINA_TRUE; + if (!buffer) return; - if (buffer->type != E_COMP_WL_BUFFER_TYPE_SHM) return EINA_TRUE; + if (buffer->type != E_COMP_WL_BUFFER_TYPE_SHM) return; /* TODO : store and use multiple onscreen_parent for geometry calculation */ onscreen_parent = parent_provider->onscreen_parent; - if (!onscreen_parent) return EINA_TRUE; + if (!onscreen_parent) return; - if (!e_view_client_visible_get(e_client_view_get(ec))) return EINA_TRUE; + if (!e_view_client_visible_get(e_client_view_get(ec))) return; e_view_client_geometry_get(e_client_view_get(ec), &fx, &fy, &fw, &fh); @@ -3194,8 +3194,6 @@ _e_comp_wl_remote_surface_subsurface_commit(E_Comp_Wl_Remote_Provider *parent_pr evas_object_move(region->mirror, x, y); evas_object_resize(region->mirror, w, h); } - - return EINA_TRUE; } static void @@ -3297,8 +3295,8 @@ e_comp_wl_remote_surface_commit(E_Client *ec) provider = _remote_provider_find(offscreen_parent); if (!provider) return EINA_FALSE; - if (!_e_comp_wl_remote_surface_subsurface_commit(provider, ec)) - return EINA_FALSE; + _e_comp_wl_remote_surface_subsurface_commit(provider, ec); + return EINA_TRUE; } -- 2.34.1