From 9968e459f1378a1c00301472cfe672497fe001d5 Mon Sep 17 00:00:00 2001 From: Mathias Krause Date: Tue, 5 Nov 2013 21:25:32 +0100 Subject: [PATCH] ACPI / event: remove unneeded NULL pointer check nla_data() cannot return NULL as it simply adds NLA_HDRLEN to the passed pointer. The NULL pointer check is therefore superfluous. Remove it. Found by smatch: drivers/acpi/event.c:130 acpi_bus_generate_netlink_event() warn: can 'event' even be NULL? Signed-off-by: Mathias Krause Signed-off-by: Rafael J. Wysocki --- drivers/acpi/event.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c index 8247fcd..fdef416 100644 --- a/drivers/acpi/event.c +++ b/drivers/acpi/event.c @@ -127,11 +127,6 @@ int acpi_bus_generate_netlink_event(const char *device_class, } event = nla_data(attr); - if (!event) { - nlmsg_free(skb); - return -EINVAL; - } - memset(event, 0, sizeof(struct acpi_genl_event)); strcpy(event->device_class, device_class); -- 2.7.4