From 9916f7dec4f475552d693ddaaccd2c7e1cce303e Mon Sep 17 00:00:00 2001
From: Vance Morrison <vancem@microsoft.com>
Date: Tue, 10 Oct 2017 11:59:29 -0700
Subject: [PATCH] Turn on source link support (#14399)

* Use Portable PDBs and turn on SourceLink

This makes us uniform.   Allows VSCode (which does not suport MSPdbs) use on Windows.

* Allow DebugType to be overridden (on the command line)

* Turn off portable PDB support for now
---
 dir.props                                  | 8 ++++++++
 src/mscorlib/System.Private.CoreLib.csproj | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/dir.props b/dir.props
index 277512f..5a9700c 100644
--- a/dir.props
+++ b/dir.props
@@ -10,6 +10,14 @@
     <OsEnvironment Condition="'$(OsEnvironment)'==''">$(OS)</OsEnvironment>
   </PropertyGroup>
 
+  <!-- Set the kind of PDB to Portable and turn on SourceLink (fetching source from GitHub) -->
+  <PropertyGroup>
+    <!-- TODO turn on Portable PDB 
+    <DebugType Condition="'$(DebugType)' == ''">Portable</DebugType> 
+     -->
+    <UseSourceLink>true</UseSourceLink>
+  </PropertyGroup>
+
   <!-- Version numbers for both managed & native binaries -->
   <PropertyGroup>
     <MajorVersion>4</MajorVersion>
diff --git a/src/mscorlib/System.Private.CoreLib.csproj b/src/mscorlib/System.Private.CoreLib.csproj
index 4919269..ca4b19e 100644
--- a/src/mscorlib/System.Private.CoreLib.csproj
+++ b/src/mscorlib/System.Private.CoreLib.csproj
@@ -73,14 +73,14 @@
     <DebugSymbols>true</DebugSymbols>
     <Optimize Condition="'$(Optimize)' == '' and '$(Configuration)' == 'Debug'">false</Optimize>
     <Optimize Condition="'$(Optimize)' == '' and '$(Configuration)' == 'Checked'">true</Optimize>
-    <DebugType>full</DebugType>
+    <DebugType Condition="'$(DebugType)' == ''">full</DebugType>
     <DefineConstants>DBG;_DEBUG;_LOGGING;DEBUG;TRACE;$(DefineConstants)</DefineConstants>
     <DefineConstants Condition="'$(Platform)' == 'x86' or '$(Platform)' == 'amd64'">CODE_ANALYSIS;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)' == 'Release'">
     <DebugSymbols>true</DebugSymbols>
     <Optimize Condition="'$(Optimize)' == ''">true</Optimize>
-    <DebugType>pdbOnly</DebugType>
+    <DebugType Condition="'$(DebugType)' == ''">pdbOnly</DebugType>
     <DefineConstants>TRACE;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
   <!-- Make portable PDBs on Unix -->
-- 
2.7.4