From 98ce1e11bc3da9d3b383a224e28a7a9b61ca7ad5 Mon Sep 17 00:00:00 2001 From: Chris Bass Date: Wed, 19 Apr 2017 14:07:06 +0100 Subject: [PATCH] ttmlparse: Fix potential NULL dereference identified by coverity Hopefully fixes CID #1405131. --- ext/ttml/ttmlparse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/ttml/ttmlparse.c b/ext/ttml/ttmlparse.c index 016523c..cb54fc3 100644 --- a/ext/ttml/ttmlparse.c +++ b/ext/ttml/ttmlparse.c @@ -734,9 +734,9 @@ ttml_style_set_inherit (TtmlStyleSet * parent, TtmlStyleSet * child) * fontSize based on the parent's fontSize; otherwise, we simply keep * the value defined in the child's style set. */ if (g_strcmp0 ((const gchar *) attr_name, "fontSize") == 0 - && ttml_style_set_contains_attr (ret, (const gchar *) attr_name)) { + && ttml_style_set_contains_attr (ret, "fontSize")) { const gchar *original_child_font_size = - ttml_style_set_get_attr (child, "fontSize"); + ttml_style_set_get_attr (ret, "fontSize"); gchar *scaled_child_font_size = ttml_get_relative_font_size ((const gchar *) attr_value, original_child_font_size); -- 2.7.4