From 98a2a7e9b663b96a0131c592521e0b3068f6aedb Mon Sep 17 00:00:00 2001 From: seoz Date: Tue, 13 Mar 2012 10:16:37 +0000 Subject: [PATCH] elm genlist: Fixed item select bug. Patch by Hyoyoung Chang On Tue, Mar 13, 2012 at 6:52 PM, Hyoyoung Chang wrote: > Dear all, > > In _item_select, some if conditional is not working as user intention. > always_select mode checking is reversed and no-select mode is not checked. > I add and fix it. > Thanks git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@69292 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/lib/elm_genlist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index 3584498..0f51665 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -3509,6 +3509,7 @@ void _item_select(Elm_Gen_Item *it) { if ((it->generation < it->wd->generation) || (it->mode_set) || + (it->select_mode == ELM_OBJECT_SELECT_MODE_NONE) || (it->wd->select_mode == ELM_OBJECT_SELECT_MODE_NONE)) return; if (!it->selected) @@ -3516,7 +3517,7 @@ _item_select(Elm_Gen_Item *it) it->selected = EINA_TRUE; it->wd->selected = eina_list_append(it->wd->selected, it); } - else if (it->wd->select_mode == ELM_OBJECT_SELECT_MODE_ALWAYS) return; + else if (it->wd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) return; evas_object_ref(WIDGET(it)); it->walking++; -- 2.7.4