From 986f1c10a1824030c7464baae6493696e11b4ace Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Mon, 10 Aug 2015 10:06:04 -0700 Subject: [PATCH] [heap] Avoid inclusion of heap internals in v8.h header. R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1283833002 Cr-Commit-Position: refs/heads/master@{#30093} --- src/DEPS | 5 ----- src/heap/heap-inl.h | 2 ++ src/v8.h | 4 +--- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/DEPS b/src/DEPS index 80dab6b..021cd3b 100644 --- a/src/DEPS +++ b/src/DEPS @@ -16,11 +16,6 @@ specific_include_rules = { "d8\.cc": [ "+include/libplatform/libplatform.h", ], - # TODO(mstarzinger): Get rid of grab-bag includes from heap in v8.h soon. - "v8\.h": [ - "+src/heap/spaces-inl.h", - "+src/heap/incremental-marking-inl.h", - ], # TODO(mstarzinger): Only needed because of Code::CodeIterateBody cyclicity. "objects\.cc": [ "+src/heap/objects-visiting-inl.h", diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h index fdb1d73..45ba379 100644 --- a/src/heap/heap-inl.h +++ b/src/heap/heap-inl.h @@ -9,6 +9,8 @@ #include "src/base/platform/platform.h" #include "src/heap/heap.h" +#include "src/heap/incremental-marking-inl.h" +#include "src/heap/spaces-inl.h" #include "src/heap/store-buffer.h" #include "src/heap/store-buffer-inl.h" #include "src/heap-profiler.h" diff --git a/src/v8.h b/src/v8.h index 41d4c36..c516cac 100644 --- a/src/v8.h +++ b/src/v8.h @@ -35,10 +35,8 @@ #include "src/flags.h" // NOLINT #include "src/globals.h" // NOLINT -// Objects & heap +// Objects #include "src/objects-inl.h" // NOLINT -#include "src/heap/spaces-inl.h" // NOLINT -#include "src/heap/incremental-marking-inl.h" // NOLINT #include "src/log-inl.h" // NOLINT #include "src/handles-inl.h" // NOLINT #include "src/types-inl.h" // NOLINT -- 2.7.4