From 986303cb928f1de3297c3f52a8ea52971e222472 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Wed, 3 Jan 2018 09:05:31 -0800 Subject: [PATCH] spirv: Require a storage type for OpStore destinations This rules out things such as trying to store a pointer to a local variable. Reviewed-by: Lionel Landwerlin --- src/compiler/spirv/vtn_variables.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 2b3b340..399860b 100644 --- a/src/compiler/spirv/vtn_variables.c +++ b/src/compiler/spirv/vtn_variables.c @@ -2009,6 +2009,10 @@ vtn_handle_variables(struct vtn_builder *b, SpvOp opcode, struct vtn_pointer *dest = dest_val->pointer; struct vtn_value *src_val = vtn_untyped_value(b, w[2]); + /* OpStore requires us to actually have a storage type */ + vtn_fail_if(dest->type->type == NULL, + "Invalid destination type for OpStore"); + vtn_fail_if(dest_val->type->deref != src_val->type, "Value and pointer types of OpStore do not match"); -- 2.7.4