From 97f89b536507a58144aaef107a7723ea06f90763 Mon Sep 17 00:00:00 2001 From: Thomas Vander Stichele Date: Thu, 4 Mar 2004 20:06:02 +0000 Subject: [PATCH] make signals use dashes in the names Original commit message from CVS: make signals use dashes in the names --- ChangeLog | 16 ++++++++++++++++ docs/random/API | 2 ++ gst/elements/gstmultifilesrc.c | 2 +- gst/gstbin.c | 4 ++-- gst/gstelement.c | 6 +++--- gst/gstindex.c | 2 +- gst/gstobject.c | 10 +++++----- gst/gstpad.c | 2 +- gst/gstregistry.c | 2 +- gst/gsturi.c | 3 +-- gst/gstxml.c | 2 +- libs/gst/control/dparam.c | 6 +++--- libs/gst/control/dparammanager.c | 3 +-- plugins/elements/gstmultifilesrc.c | 2 +- 14 files changed, 39 insertions(+), 23 deletions(-) create mode 100644 docs/random/API diff --git a/ChangeLog b/ChangeLog index 5c0d506..a291c06 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,19 @@ +2004-03-04 Thomas Vander Stichele + + * gst/elements/gstmultifilesrc.c: (gst_multifilesrc_class_init): + * gst/gstbin.c: (gst_bin_class_init): + * gst/gstelement.c: (gst_element_class_init): + * gst/gstindex.c: (gst_index_class_init): + * gst/gstobject.c: (gst_object_class_init), + (gst_signal_object_class_init): + * gst/gstpad.c: (gst_pad_template_class_init): + * gst/gstregistry.c: (gst_registry_class_init): + * gst/gsturi.c: (gst_uri_handler_base_init): + * gst/gstxml.c: (gst_xml_class_init): + * libs/gst/control/dparam.c: (gst_dparam_class_init): + * libs/gst/control/dparammanager.c: (gst_dpman_class_init): + make all signal names use dashes instead of underscore + 2004-03-03 Thomas Vander Stichele * configure.ac: AC_SUBST GLIB_ONLY CFLAGS and LIBS diff --git a/docs/random/API b/docs/random/API new file mode 100644 index 0000000..4962b32 --- /dev/null +++ b/docs/random/API @@ -0,0 +1,2 @@ +* signals should use dashes in their names, not underscores, so ::notify + works correctly diff --git a/gst/elements/gstmultifilesrc.c b/gst/elements/gstmultifilesrc.c index 454acf6..b24fca9 100644 --- a/gst/elements/gstmultifilesrc.c +++ b/gst/elements/gstmultifilesrc.c @@ -94,7 +94,7 @@ gst_multifilesrc_class_init (GstMultiFileSrcClass *klass) gst_multifilesrc_signals[NEW_FILE] = - g_signal_new ("new_file", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, + g_signal_new ("new-file", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstMultiFileSrcClass, new_file), NULL, NULL, g_cclosure_marshal_VOID__STRING, G_TYPE_NONE, 1, G_TYPE_STRING); diff --git a/gst/gstbin.c b/gst/gstbin.c index 4c05978..ba6d6ea 100644 --- a/gst/gstbin.c +++ b/gst/gstbin.c @@ -135,11 +135,11 @@ gst_bin_class_init (GstBinClass * klass) parent_class = g_type_class_ref (GST_TYPE_ELEMENT); gst_bin_signals[ELEMENT_ADDED] = - g_signal_new ("element_added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_FIRST, + g_signal_new ("element-added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_FIRST, G_STRUCT_OFFSET (GstBinClass, element_added), NULL, NULL, gst_marshal_VOID__OBJECT, G_TYPE_NONE, 1, GST_TYPE_ELEMENT); gst_bin_signals[ELEMENT_REMOVED] = - g_signal_new ("element_removed", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_FIRST, + g_signal_new ("element-removed", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_FIRST, G_STRUCT_OFFSET (GstBinClass, element_removed), NULL, NULL, gst_marshal_VOID__OBJECT, G_TYPE_NONE, 1, GST_TYPE_ELEMENT); gst_bin_signals[ITERATE] = diff --git a/gst/gstelement.c b/gst/gstelement.c index 8383ac2..7b076c4 100644 --- a/gst/gstelement.c +++ b/gst/gstelement.c @@ -115,17 +115,17 @@ gst_element_class_init (GstElementClass *klass) parent_class = g_type_class_ref(GST_TYPE_OBJECT); gst_element_signals[STATE_CHANGE] = - g_signal_new ("state_change", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("state-change", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstElementClass, state_change), NULL, NULL, gst_marshal_VOID__INT_INT, G_TYPE_NONE, 2, G_TYPE_INT, G_TYPE_INT); gst_element_signals[NEW_PAD] = - g_signal_new ("new_pad", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("new-pad", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstElementClass, new_pad), NULL, NULL, gst_marshal_VOID__OBJECT, G_TYPE_NONE, 1, G_TYPE_OBJECT); gst_element_signals[PAD_REMOVED] = - g_signal_new ("pad_removed", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("pad-removed", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstElementClass, pad_removed), NULL, NULL, gst_marshal_VOID__OBJECT, G_TYPE_NONE, 1, G_TYPE_OBJECT); diff --git a/gst/gstindex.c b/gst/gstindex.c index 4f33269..342331e 100644 --- a/gst/gstindex.c +++ b/gst/gstindex.c @@ -138,7 +138,7 @@ gst_index_class_init (GstIndexClass *klass) parent_class = g_type_class_ref(GST_TYPE_OBJECT); gst_index_signals[ENTRY_ADDED] = - g_signal_new ("entry_added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("entry-added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstIndexClass, entry_added), NULL, NULL, gst_marshal_VOID__BOXED, G_TYPE_NONE, 1, GST_TYPE_INDEX_ENTRY); diff --git a/gst/gstobject.c b/gst/gstobject.c index 2b64ea8..474c77c 100644 --- a/gst/gstobject.c +++ b/gst/gstobject.c @@ -130,19 +130,19 @@ gst_object_class_init (GstObjectClass *klass) NULL, G_PARAM_READWRITE)); gst_object_signals[PARENT_SET] = - g_signal_new ("parent_set", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("parent-set", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstObjectClass, parent_set), NULL, NULL, g_cclosure_marshal_VOID__OBJECT, G_TYPE_NONE, 1, G_TYPE_OBJECT); gst_object_signals[PARENT_UNSET] = - g_signal_new ("parent_unset", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("parent-unset", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstObjectClass, parent_unset), NULL, NULL, g_cclosure_marshal_VOID__OBJECT, G_TYPE_NONE, 1, G_TYPE_OBJECT); #ifndef GST_DISABLE_LOADSAVE_REGISTRY /* FIXME This should be the GType of xmlNodePtr instead of G_TYPE_POINTER */ gst_object_signals[OBJECT_SAVED] = - g_signal_new ("object_saved", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("object-saved", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstObjectClass, object_saved), NULL, NULL, g_cclosure_marshal_VOID__POINTER, G_TYPE_NONE, 1, G_TYPE_POINTER); @@ -150,7 +150,7 @@ gst_object_class_init (GstObjectClass *klass) klass->restore_thyself = gst_object_real_restore_thyself; #endif gst_object_signals[DEEP_NOTIFY] = - g_signal_new ("deep_notify", G_TYPE_FROM_CLASS (klass), + g_signal_new ("deep-notify", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_FIRST | G_SIGNAL_NO_RECURSE | G_SIGNAL_DETAILED | G_SIGNAL_NO_HOOKS, G_STRUCT_OFFSET (GstObjectClass, deep_notify), NULL, NULL, gst_marshal_VOID__OBJECT_PARAM, G_TYPE_NONE, @@ -808,7 +808,7 @@ gst_signal_object_class_init (GstSignalObjectClass *klass) #ifndef GST_DISABLE_LOADSAVE_REGISTRY gst_signal_object_signals[SO_OBJECT_LOADED] = - g_signal_new ("object_loaded", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("object-loaded", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstSignalObjectClass, object_loaded), NULL, NULL, gst_marshal_VOID__OBJECT_POINTER, G_TYPE_NONE, 2, G_TYPE_OBJECT, G_TYPE_POINTER); diff --git a/gst/gstpad.c b/gst/gstpad.c index 636ef42..aa5d103 100644 --- a/gst/gstpad.c +++ b/gst/gstpad.c @@ -3204,7 +3204,7 @@ gst_pad_template_class_init (GstPadTemplateClass *klass) padtemplate_parent_class = g_type_class_ref (GST_TYPE_OBJECT); gst_pad_template_signals[TEMPL_PAD_CREATED] = - g_signal_new ("pad_created", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("pad-created", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstPadTemplateClass, pad_created), NULL, NULL, gst_marshal_VOID__OBJECT, G_TYPE_NONE, 1, GST_TYPE_PAD); diff --git a/gst/gstregistry.c b/gst/gstregistry.c index df0f856..73d4813 100644 --- a/gst/gstregistry.c +++ b/gst/gstregistry.c @@ -82,7 +82,7 @@ gst_registry_class_init (GstRegistryClass *klass) parent_class = g_type_class_ref (G_TYPE_OBJECT); gst_registry_signals[PLUGIN_ADDED] = - g_signal_new ("plugin_added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, + g_signal_new ("plugin-added", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstRegistryClass, plugin_added), NULL, NULL, gst_marshal_VOID__POINTER, G_TYPE_NONE, 1, G_TYPE_POINTER); diff --git a/gst/gsturi.c b/gst/gsturi.c index 3a003d4..ef9e030 100644 --- a/gst/gsturi.c +++ b/gst/gsturi.c @@ -67,13 +67,12 @@ gst_uri_handler_base_init (gpointer g_class) static gboolean initialized = FALSE; if (!initialized) { - g_signal_new ("new_uri", GST_TYPE_URI_HANDLER, G_SIGNAL_RUN_LAST, + g_signal_new ("new-uri", GST_TYPE_URI_HANDLER, G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstURIHandlerInterface, new_uri), NULL, NULL, gst_marshal_VOID__STRING, G_TYPE_NONE, 1, G_TYPE_STRING); initialized = TRUE; } } - static void gst_uri_protocol_check_internal (const gchar *uri, gchar **endptr) diff --git a/gst/gstxml.c b/gst/gstxml.c index aaa3775..35b9407 100644 --- a/gst/gstxml.c +++ b/gst/gstxml.c @@ -74,7 +74,7 @@ gst_xml_class_init (GstXMLClass *klass) /* FIXME G_TYPE_POINTER should be GType of xmlNodePtr */ gst_xml_signals[OBJECT_LOADED] = - g_signal_new ("object_loaded", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, + g_signal_new ("object-loaded", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstXMLClass, object_loaded), NULL, NULL, gst_marshal_VOID__OBJECT_POINTER, G_TYPE_NONE, 2, GST_TYPE_OBJECT, G_TYPE_POINTER); diff --git a/libs/gst/control/dparam.c b/libs/gst/control/dparam.c index 46bc09c..9c07adb 100644 --- a/libs/gst/control/dparam.c +++ b/libs/gst/control/dparam.c @@ -105,11 +105,11 @@ gst_dparam_class_init (GstDParamClass *klass) g_param_spec_int64("value_int64","64 bit Integer Value", "The value that should be changed if gint64 is the type", G_MININT64, G_MAXINT64, 0, G_PARAM_READWRITE)); - + gobject_class->dispose = gst_dparam_dispose; - + gst_dparam_signals[VALUE_CHANGED] = - g_signal_new ("value_changed", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, + g_signal_new ("value-changed", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstDParamClass, value_changed), NULL, NULL, gst_marshal_VOID__VOID, G_TYPE_NONE, 0); /*gstobject_class->save_thyself = gst_dparam_save_thyself; */ diff --git a/libs/gst/control/dparammanager.c b/libs/gst/control/dparammanager.c index 54aca71..6393522 100644 --- a/libs/gst/control/dparammanager.c +++ b/libs/gst/control/dparammanager.c @@ -112,11 +112,10 @@ gst_dpman_class_init (GstDParamManagerClass *klass) gst_dpman_signals[NEW_REQUIRED_DPARAM] = - g_signal_new ("new_required_dparam", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, + g_signal_new ("new-required-dparam", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstDParamManagerClass, new_required_dparam), NULL, NULL, gst_marshal_VOID__STRING, G_TYPE_NONE, 1, G_TYPE_STRING); - } static void diff --git a/plugins/elements/gstmultifilesrc.c b/plugins/elements/gstmultifilesrc.c index 454acf6..b24fca9 100644 --- a/plugins/elements/gstmultifilesrc.c +++ b/plugins/elements/gstmultifilesrc.c @@ -94,7 +94,7 @@ gst_multifilesrc_class_init (GstMultiFileSrcClass *klass) gst_multifilesrc_signals[NEW_FILE] = - g_signal_new ("new_file", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, + g_signal_new ("new-file", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GstMultiFileSrcClass, new_file), NULL, NULL, g_cclosure_marshal_VOID__STRING, G_TYPE_NONE, 1, G_TYPE_STRING); -- 2.7.4