From 97e804750cdc7a259d0e61f32dabc244dea09c49 Mon Sep 17 00:00:00 2001 From: Minkyu Kang Date: Tue, 7 Feb 2017 15:00:35 -0800 Subject: [PATCH] elm_genlist: do not check scroll if show_item is NULL Summary: If show_item is NULL then does not need to check scroll. But, sometimes show_item is NULL but check_scroll is true. It was wrong and can makes a crash. Signed-off-by: Minkyu Kang Reviewers: cedric, Hermet, SanghyeonLee, raster Subscribers: jpeg Differential Revision: https://phab.enlightenment.org/D4569 Change-Id: If4ed681fc14b7b8535eb065c7ee81aea251e80eb Signed-off-by: Cedric BAIL --- src/lib/elm_genlist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index 7b0bcc3..cd181d8 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -875,6 +875,7 @@ _calc_job(void *data) if (!sd->must_recalc_idler) sd->must_recalc_idler = ecore_idler_add(_must_recalc_idler, data); } + if (!sd->show_item) sd->check_scroll = EINA_FALSE; if (sd->check_scroll) { eo_do(sd->pan_obj, elm_obj_pan_content_size_get(&pan_w, &pan_h)); -- 2.7.4