From 97c7d9bec4c9fc4e8aac9d49a503e04a93f36085 Mon Sep 17 00:00:00 2001 From: Jae Yong Hwang Date: Thu, 21 Aug 2014 22:49:36 +0900 Subject: [PATCH] genlist: Fixed item select logic when item select mode is ALWAYS. Summary: ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked. So, I added the check routine there. @fix Test Plan: I revised the elementary_test code and tested with that. Reviewers: raster, seoz Reviewed By: seoz Subscribers: SanghyeonLee, bluezery Differential Revision: https://phab.enlightenment.org/D1347 --- src/lib/elm_genlist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index 0631279..6562704 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -5546,7 +5546,8 @@ _item_select(Elm_Gen_Item *it) sd->selected = eina_list_append(sd->selected, it); } - else if (sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) + else if ((sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) && + (it->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS)) return; evas_object_ref(obj); -- 2.7.4