From 9797a32fafd61c3dd221ed69137420e387c7eb89 Mon Sep 17 00:00:00 2001 From: Rohan Varma Date: Thu, 9 Sep 2021 12:05:26 -0700 Subject: [PATCH] [Dist/CI] Remove dist from target determinator (#64721) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/64721 There are a couple PRs where distributed CI did not runa nd we expect it to. Examples: https://github.com/pytorch/pytorch/pull/64513/checks?check_run_id=3539190960, https://github.com/pytorch/pytorch/pull/64113. All distributed tests should've been run on these PRs, but we can see they were not: ``` Determination is skipping distributed/test_c10d_common Determination is skipping distributed/test_c10d_gloo Determination is skipping distributed/test_c10d_nccl Determination is skipping distributed/test_c10d_spawn_gloo Determination is skipping distributed/test_c10d_spawn_nccl Running distributed/test_data_parallel without determination Determination is skipping distributed/test_distributed_spawn Determination is skipping distributed/test_jit_c10d ``` Since it is important to run distributed tests on PRs that touch distributed, exclude distributed from target_det_list for now. ghstack-source-id: 137654015 Test Plan: CI Reviewed By: driazati, mrshenli Differential Revision: D30830455 fbshipit-source-id: 8b0fdf5b57c2c647b0d82c48e2bb8e2bdbe4d307 --- test/test_determination.py | 1 - tools/testing/modulefinder_determinator.py | 36 ------------------------------ 2 files changed, 37 deletions(-) diff --git a/test/test_determination.py b/test/test_determination.py index ca00835..395467d 100644 --- a/test/test_determination.py +++ b/test/test_determination.py @@ -16,7 +16,6 @@ class DeterminationTest(unittest.TestCase): "test_jit_profiling", "test_jit", "test_torch", - "distributed/test_distributed_spawn", "test_cpp_extensions_aot_ninja", "test_cpp_extensions_aot_no_ninja", "test_utils", diff --git a/tools/testing/modulefinder_determinator.py b/tools/testing/modulefinder_determinator.py index 32dc103..f041be1 100644 --- a/tools/testing/modulefinder_determinator.py +++ b/tools/testing/modulefinder_determinator.py @@ -12,42 +12,6 @@ REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent.parent # run with --determine-from, we use another generated list based on this one and the # previous test stats. TARGET_DET_LIST = [ - "distributed/algorithms/ddp_comm_hooks/test_ddp_hooks", - "distributed/nn/jit/test_instantiator", - "distributed/pipeline/sync/skip/test_api", - "distributed/pipeline/sync/skip/test_gpipe", - "distributed/pipeline/sync/skip/test_inspect_skip_layout", - "distributed/pipeline/sync/skip/test_leak", - "distributed/pipeline/sync/skip/test_portal", - "distributed/pipeline/sync/skip/test_stash_pop", - "distributed/pipeline/sync/skip/test_tracker", - "distributed/pipeline/sync/skip/test_verify_skippables", - "distributed/pipeline/sync/test_balance", - "distributed/pipeline/sync/test_bugs", - "distributed/pipeline/sync/test_checkpoint", - "distributed/pipeline/sync/test_copy", - "distributed/pipeline/sync/test_deferred_batch_norm", - "distributed/pipeline/sync/test_dependency", - "distributed/pipeline/sync/test_inplace", - "distributed/pipeline/sync/test_microbatch", - "distributed/pipeline/sync/test_phony", - "distributed/pipeline/sync/test_pipe", - "distributed/pipeline/sync/test_pipeline", - "distributed/pipeline/sync/test_stream", - "distributed/pipeline/sync/test_transparency", - "distributed/pipeline/sync/test_worker", - "distributed/rpc/cuda/test_tensorpipe_agent", - "distributed/rpc/test_tensorpipe_agent", - "distributed/test_c10d_common", - "distributed/test_c10d_gloo", - "distributed/test_c10d_nccl", - "distributed/test_c10d_spawn_gloo", - "distributed/test_c10d_spawn_nccl", - "distributed/test_distributed_spawn", - "distributed/test_jit_c10d", - "distributed/test_pg_wrapper", - "distributed/test_store", - "distributions/test_distributions", # test_autograd.py is not slow, so it does not belong here. But # note that if you try to add it back it will run into # https://bugs.python.org/issue40350 because it imports files -- 2.7.4