From 9792838905bb2462c7d58ac0817bed2942e994de Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Sun, 15 Apr 2018 18:59:38 +0000 Subject: [PATCH] [SelectionDAG][NFC] haveNoCommonBitsSet(): add FIXME notes As suggested in https://reviews.llvm.org/D45631#1068338 llvm-svn: 330102 --- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp index d35a940..d57f0bf 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp @@ -3636,6 +3636,8 @@ bool SelectionDAG::isEqualTo(SDValue A, SDValue B) const { return false; } +// FIXME: unify with llvm::haveNoCommonBitsSet. +// FIXME: could also handle masked merge pattern (X & ~M) op (Y & M) bool SelectionDAG::haveNoCommonBitsSet(SDValue A, SDValue B) const { assert(A.getValueType() == B.getValueType() && "Values must have the same type"); -- 2.7.4