From 976fcc04dc2f6c73142948910303a3612f529c28 Mon Sep 17 00:00:00 2001 From: Djalal Harouni Date: Mon, 20 Oct 2014 21:04:11 +0100 Subject: [PATCH] message: minor optimization no need to pass invalid fds to fget() Signed-off-by: Djalal Harouni --- message.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/message.c b/message.c index 98e92d4..2c57626 100644 --- a/message.c +++ b/message.c @@ -172,9 +172,9 @@ static int kdbus_msg_scan_items(struct kdbus_conn *conn, case KDBUS_ITEM_PAYLOAD_MEMFD: { int seals, mask; + int fd = item->memfd.fd; - f = fget(item->memfd.fd); - if (!f) + if (fd < 0 || !(f = fget(fd))) return -EBADF; kmsg->memfds[kmsg->memfds_count] = f; @@ -227,9 +227,9 @@ static int kdbus_msg_scan_items(struct kdbus_conn *conn, for (i = 0; i < n; i++) { int ret; + int fd = item->fds[i]; - f = fget(item->fds[i]); - if (!f) + if (fd < 0 || !(f = fget(fd))) return -EBADF; kmsg->fds[i] = f; -- 2.34.1