From 971e834a8da9ef98bcf6b03ffc5b9eeac055095d Mon Sep 17 00:00:00 2001 From: "fschneider@chromium.org" Date: Thu, 18 Oct 2012 11:18:08 +0000 Subject: [PATCH] Always invoke the default Array.sort functions from builtin functions. TEST=mjsunit/regress/regress-builtin-array-op.js BUG=v8:2372 Review URL: https://chromiumcodereview.appspot.com/10559005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/array.js | 2 +- test/mjsunit/regress/regress-builtin-array-op.js | 37 ++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 test/mjsunit/regress/regress-builtin-array-op.js diff --git a/src/array.js b/src/array.js index 1cedd8d..ab68c58 100644 --- a/src/array.js +++ b/src/array.js @@ -62,7 +62,7 @@ function GetSortedArrayKeys(array, intervals) { } } } - keys.sort(function(a, b) { return a - b; }); + ArraySort.call(keys, function(a, b) { return a - b; }); return keys; } diff --git a/test/mjsunit/regress/regress-builtin-array-op.js b/test/mjsunit/regress/regress-builtin-array-op.js new file mode 100644 index 0000000..2ea84d3 --- /dev/null +++ b/test/mjsunit/regress/regress-builtin-array-op.js @@ -0,0 +1,37 @@ +// Copyright 2012 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Test that we invoke the correct sort function in +// array operations. + +var foo = "hest"; +Array.prototype.sort = function(fn) { foo = "fisk"; } +var a = [2,3,1]; +a[100000] = 0; +a.join(); +assertEquals("hest", foo); + -- 2.7.4