From 96be65d12d792b3e177505db1225e1ec4f9cf5cd Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Fri, 1 Feb 2019 09:18:41 +0000 Subject: [PATCH] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe() It's not necessary to remove gpio_chip which added with devm_gpiochip_add_data(). Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") Signed-off-by: Wei Yongjun Reviewed-by: Andrew Lunn Signed-off-by: Linus Walleij --- drivers/gpio/gpio-tqmx86.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index 6f7250c..33dbe48 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) IRQ_TYPE_EDGE_BOTH); if (ret) { dev_err(dev, "Could not add irq chip\n"); - goto out_remove; + goto out_pm_dis; } gpiochip_set_chained_irqchip(chip, irq_chip, @@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) return 0; -out_remove: - gpiochip_remove(&gpio->chip); out_pm_dis: pm_runtime_disable(&pdev->dev); -- 2.7.4