From 96a911a8dbf2e620040b9d60c3bfa4a3c7fa0563 Mon Sep 17 00:00:00 2001 From: Seung-Woo Kim Date: Fri, 3 Nov 2017 18:33:39 +0900 Subject: [PATCH] spl: serial_bcm283x: remove unnecessary gpio setting The config.txt has enable_uart=1 option, so bootcode.bin will set register to enable uart, so spl of rpi3 does not need to set uart register. Remove the unnecessary setting to remove garbage in uart rx. This fixes unexpected hang-up on u-boot prompt without connection uart to serial console. Change-Id: I813b4304e434c0f3d51d06078b38d09adb7b993d Signed-off-by: Seung-Woo Kim --- drivers/serial/serial_bcm283x_mu.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/serial/serial_bcm283x_mu.c b/drivers/serial/serial_bcm283x_mu.c index 5bed94a..2030952 100644 --- a/drivers/serial/serial_bcm283x_mu.c +++ b/drivers/serial/serial_bcm283x_mu.c @@ -229,26 +229,10 @@ U_BOOT_DRIVER(serial_bcm283x_mu) = { static inline void _debug_uart_init(void) { - int i; - - AUX_ENB |= 1; /* Enable mini-uart */ - MU_LCR = 3; /* 8 bit. */ - MU_BAUD = 270; /* 115200 baud.(0x10e) */ - - GPFSEL1 &= ~((7<<12) | (7 << 15)); /* GPIO14 & 15 : alt5 */ - GPFSEL1 |= (2 << 12) | (2 << 15); - - /* Disable pull-up/down */ - GPPUD = 0; - for (i = 0; i < 150; i++) - __asm__ __volatile__("nop"); - GPPUDCLK0 = (2 << 14) | (2 << 15); - for (i = 0; i < 150; i++) - __asm__ __volatile__("nop"); - - GPPUDCLK0 = 0; - - MU_CNTL = 3; /* Enable Tx & Rx */ + /* + * uart setting is already done from bootcode.bin + * with enable_uart=1 in config.txt + */ } static inline void _debug_uart_putc(int ch) -- 2.7.4