From 964ae32aac793540a49c44efab878592394d48db Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Sat, 20 Oct 2018 07:39:18 +0330 Subject: [PATCH] Run valgrind on run-shape-fuzzer only when RUN_VALGRIND is set (#1285) --- .circleci/config.yml | 2 +- test/fuzzing/run-shape-fuzzer-tests.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d661a14..e73f53c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -102,7 +102,7 @@ jobs: - run: make -j32 # run-shape-fuzzer-tests.py automatically runs valgrind if see available # but test/api runs it by request, we probably should normalize the approaches - - run: make check && make -Ctest/api check-valgrind || .ci/fail.sh + - run: RUN_VALGRIND=1 make check && make -Ctest/api check-valgrind || .ci/fail.sh # informational for now - run: make -Ctest/api check-symbols || true diff --git a/test/fuzzing/run-shape-fuzzer-tests.py b/test/fuzzing/run-shape-fuzzer-tests.py index dcdab67..53c4f50 100755 --- a/test/fuzzing/run-shape-fuzzer-tests.py +++ b/test/fuzzing/run-shape-fuzzer-tests.py @@ -67,7 +67,9 @@ please provide it as the first argument to the tool""") print ('hb_shape_fuzzer:', hb_shape_fuzzer) fails = 0 -valgrind = which ('valgrind') +valgrind = None +if os.environ.get('RUN_VALGRIND', ''): + valgrind = which ('valgrind') parent_path = os.path.join (srcdir, "fonts") for file in os.listdir (parent_path): -- 2.7.4