From 960d6a0e1dcac135b9227603eaa2c35b1943d4f3 Mon Sep 17 00:00:00 2001 From: Jaechan Lee Date: Fri, 25 Nov 2016 18:49:47 +0900 Subject: [PATCH] [subtitle] subtitle_cb is called after EOS. [Model] Tizen3.0 Z2 [BinType] AP [Customer] OPEN [Issue#] N/A [Request] Monitoring test [Occurrence Version] Z200FDDE0APK7 [Problem] Despite the video is played until EOS, subtitle can be updated. [Cause & Measure] Cause : Although, the drop-probability property of identity plugin is changed as "0.0", in this case, the last buffer of fakesink is remained. So, subtitle_cb will be called after EOS just once. Measure : the update of subtitle is prohibited after EOS. [Checking Method] player_test > play video files with subtitle. [Team] MMFW [Developer] Jaechan Lee [Solution company] Samsung [Change Type] N/A Change-Id: Ia0c804ccd7ce6d37b995a5687830ad83a8806c3a --- src/mm_player_priv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 77c00f2..34180c2 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -5724,6 +5724,12 @@ __mmplayer_update_subtitle(GstElement* object, GstBuffer *buffer, GstPad *pad, g MMPLAYER_RETURN_VAL_IF_FAIL(player, FALSE); MMPLAYER_RETURN_VAL_IF_FAIL(buffer, FALSE); + if (player->is_subtitle_force_drop) + { + LOGW("subtitle is dropped forcedly."); + return ret; + } + gst_buffer_map(buffer, &mapinfo, GST_MAP_READ); text = mapinfo.data; text_size = mapinfo.size; -- 2.7.4