From 95ad971d0f9a038bd2b38e893e2a8fa599ed32ac Mon Sep 17 00:00:00 2001 From: "mvstanton@chromium.org" Date: Tue, 11 Feb 2014 09:06:13 +0000 Subject: [PATCH] Fix gcstress test failure Map collection complicates a test that wants to assert on code opt/deopt because of prototype-chain changes. It can happen that a gc occurs in the stack guard at the start of optimized function foo that deopts function foo because of a map being collected and deoptimizing it's dependent code. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/159653002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/getters-on-elements.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/mjsunit/getters-on-elements.js b/test/mjsunit/getters-on-elements.js index 55fc86b..3bc360f 100644 --- a/test/mjsunit/getters-on-elements.js +++ b/test/mjsunit/getters-on-elements.js @@ -26,10 +26,17 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Flags: --allow-natives-syntax --max-opt-count=100 --noalways-opt +// Flags: --nocollect-maps // We specify max-opt-count because we opt/deopt the same function many // times. +// We specify nocollect-maps because in gcstress we can end up deoptimizing +// a function in a gc in the stack guard at the beginning of the (optimized) +// function due to leftover map clearing work that results in deoptimizing +// dependent code from those maps. The choice is to insert strategic gc() +// calls or specify this flag. + // It's nice to run this in other browsers too. var standalone = false; if (standalone) { -- 2.7.4