From 957a6c6bedfa87e5384703724c18ddeada9e189e Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Tue, 17 Sep 2019 14:56:11 +0000 Subject: [PATCH] [clangd] Fix another TSAN issue llvm-svn: 372128 --- clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp b/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp index 5dbfca5..db05c70 100644 --- a/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp +++ b/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp @@ -769,12 +769,14 @@ TEST_F(TUSchedulerTests, CommandLineWarnings) { // We should not see warnings from command-line parsing. CDB.ExtraClangFlags = {"-Wsome-unknown-warning"}; + // (!) 'Ready' must live longer than TUScheduler. + Notification Ready; + TUScheduler S(CDB, /*AsyncThreadsCount=*/getDefaultAsyncThreadsCount(), /*StorePreambleInMemory=*/true, /*ASTCallbacks=*/captureDiags(), /*UpdateDebounce=*/std::chrono::steady_clock::duration::zero(), ASTRetentionPolicy()); - Notification Ready; std::vector Diagnostics; updateWithDiags(S, testPath("foo.cpp"), "void test() {}", WantDiagnostics::Yes, [&](std::vector D) { -- 2.7.4