From 9575d1c772378df73cd421997b70d4a880575911 Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Fri, 24 Aug 2018 16:48:13 +0100 Subject: [PATCH] tests: Use volatile pointer for NULL dereference Clang warns that it can silently discard a non-volatile write to a NULL pointer (perhaps it constitutes undefined behaviour?), and recommends changing it to volatile. This patch slavishly complies with the demand of the unfeeling machine. Signed-off-by: Daniel Stone Reviewed-by: Pekka Paalanen Reviewed-by: Peter Hutterer --- tests/sanity-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/sanity-test.c b/tests/sanity-test.c index 66ca16f..2495a11 100644 --- a/tests/sanity-test.c +++ b/tests/sanity-test.c @@ -70,8 +70,10 @@ FAIL_TEST(fail_kill) FAIL_TEST(fail_segv) { + char * volatile *null = 0; + test_disable_coredumps(); - * (char **) 0 = "Goodbye, world"; + *null = "Goodbye, world"; } FAIL_TEST(sanity_assert) -- 2.7.4