From 956b969616b9eecfea158882835645fe65bcd429 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 22 Feb 2022 11:45:54 -0500 Subject: [PATCH] pan/bi: Clarify requirement for barriers Barriers need to wait on all outstanding messages. This is more of an API requirement than a hardware requirement, but it's still an invariant the scoreboarding pass must respect. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_scoreboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/bifrost/bi_scoreboard.c b/src/panfrost/bifrost/bi_scoreboard.c index 1e7ca0e..484f8a7 100644 --- a/src/panfrost/bifrost/bi_scoreboard.c +++ b/src/panfrost/bifrost/bi_scoreboard.c @@ -38,7 +38,7 @@ * 3. The shader must wait on slot #6 before running BLEND, ATEST * 4. The shader must wait on slot #7 before running BLEND, ST_TILE * 5. ATEST, ZS_EMIT must be issued with slot #0 - * 6. BARRIER must be issued with slot #7 + * 6. BARRIER must be issued with slot #7 and wait on every active slot. * 7. Only slots #0 through #5 may be used for clauses not otherwise specified. * 8. If a clause writes to a read staging register of an unresolved * dependency, it must set a staging barrier. -- 2.7.4