From 956876408a64135d8448f2f55fc9213003edb40e Mon Sep 17 00:00:00 2001 From: Nicolas Despres Date: Wed, 9 Dec 2015 23:18:18 +0100 Subject: [PATCH] Do not attempt to rebuild infinitely in dry-run mode. --- src/ninja.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ninja.cc b/src/ninja.cc index 21dede6..a73f83c 100644 --- a/src/ninja.cc +++ b/src/ninja.cc @@ -1135,6 +1135,10 @@ int real_main(int argc, char** argv) { // Attempt to rebuild the manifest before building anything else if (ninja.RebuildManifest(options.input_file, &err)) { + // In dry_run mode the regeneration will succeed without changing the + // manifest forever. Better to return immediately. + if (config.dry_run) + return 0; // Start the build over with the new manifest. continue; } else if (!err.empty()) { -- 2.7.4