From 955f3c21260b7036d3bf75278074dfdbf51ce9ec Mon Sep 17 00:00:00 2001 From: Sinan Kaya <41809318+franksinankaya@users.noreply.github.com> Date: Tue, 8 Oct 2019 16:09:24 -0700 Subject: [PATCH] Rename genAlignLoops (dotnet/coreclr#27030) * find src/jit -type f -exec sed -i -e 's/.*declspec.*genAlignLoops.*//g' {} \; * Go back to doAlignLoops * Rename to ShouldAlignLoops Commit migrated from https://github.com/dotnet/coreclr/commit/8df2e7b38211e0a2b6bad706a473f181ec1cb3fb --- src/coreclr/src/jit/codegeninterface.h | 6 +++--- src/coreclr/src/jit/codegenlinear.cpp | 2 +- src/coreclr/src/jit/compiler.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/coreclr/src/jit/codegeninterface.h b/src/coreclr/src/jit/codegeninterface.h index 7e902c2aaae..cc00fc8e5da 100644 --- a/src/coreclr/src/jit/codegeninterface.h +++ b/src/coreclr/src/jit/codegeninterface.h @@ -75,12 +75,12 @@ public: //------------------------------------------------------------------------- // The following property indicates whether to align loops. // (Used to avoid effects of loop alignment when diagnosing perf issues.) - __declspec(property(get = doAlignLoops, put = setAlignLoops)) bool genAlignLoops; - bool doAlignLoops() + + bool ShouldAlignLoops() { return m_genAlignLoops; } - void setAlignLoops(bool value) + void SetAlignLoops(bool value) { m_genAlignLoops = value; } diff --git a/src/coreclr/src/jit/codegenlinear.cpp b/src/coreclr/src/jit/codegenlinear.cpp index d1a636e2cc0..8d92a74cc33 100644 --- a/src/coreclr/src/jit/codegenlinear.cpp +++ b/src/coreclr/src/jit/codegenlinear.cpp @@ -310,7 +310,7 @@ void CodeGen::genCodeForBBlist() genUpdateCurrentFunclet(block); #ifdef _TARGET_XARCH_ - if (genAlignLoops && block->bbFlags & BBF_LOOP_HEAD) + if (ShouldAlignLoops() && block->bbFlags & BBF_LOOP_HEAD) { GetEmitter()->emitLoopAlign(); } diff --git a/src/coreclr/src/jit/compiler.cpp b/src/coreclr/src/jit/compiler.cpp index 9ee0231f027..10d845078ee 100644 --- a/src/coreclr/src/jit/compiler.cpp +++ b/src/coreclr/src/jit/compiler.cpp @@ -4040,7 +4040,7 @@ _SetMinOpts: if (opts.jitFlags->IsSet(JitFlags::JIT_FLAG_RELOC)) { - codeGen->genAlignLoops = false; // loop alignment not supported for prejitted code + codeGen->SetAlignLoops(false); // loop alignment not supported for prejitted code // The zapper doesn't set JitFlags::JIT_FLAG_ALIGN_LOOPS, and there is // no reason for it to set it as the JIT doesn't currently support loop alignment @@ -4050,7 +4050,7 @@ _SetMinOpts: } else { - codeGen->genAlignLoops = opts.jitFlags->IsSet(JitFlags::JIT_FLAG_ALIGN_LOOPS); + codeGen->SetAlignLoops(opts.jitFlags->IsSet(JitFlags::JIT_FLAG_ALIGN_LOOPS)); } } -- 2.34.1