From 9530e6cf2ee53fb8b424a23bd1cacdab709874e6 Mon Sep 17 00:00:00 2001 From: Milind Ramesh Murhekar Date: Fri, 21 Jul 2017 17:30:26 +0530 Subject: [PATCH] Avoid possible memory leak Decription: This patch avoids memory allocation when dealing with g_variant_get() and g_variant_iter_loop(). Change-Id: Ib324dffb7e03ac0d17f2e87951c69352ea5bbb90 Signed-off-by: Milind Ramesh Murhekar --- src/signal-handler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/signal-handler.c b/src/signal-handler.c index 504a3bf..546ef2b 100755 --- a/src/signal-handler.c +++ b/src/signal-handler.c @@ -107,7 +107,7 @@ static void __netconfig_extract_ipv4_signal_data(GVariant *dictionary, const gch g_variant_iter_init(&iter, dictionary); while (g_variant_iter_loop(&iter, "{sv}", &key, &var)) { if (g_strcmp0(key, "Address") == 0) { - value = g_variant_get_string(var, NULL); + g_variant_get(var, "&s", &value); char *old_ip = vconf_get_str(VCONFKEY_NETWORK_IP); DBG("Old IPv4.Address [%s] Received new IPv4.Address [%s]", old_ip, value); @@ -132,7 +132,7 @@ static void __netconfig_extract_ipv6_signal_data(GVariant *dictionary, const gch g_variant_iter_init(&iter, dictionary); while (g_variant_iter_loop(&iter, "{sv}", &key, &var)) { if (g_strcmp0(key, "Address") == 0) { - value = g_variant_get_string(var, NULL); + g_variant_get(var, "&s", &value); char *old_ip6 = vconf_get_str(VCONFKEY_NETWORK_IP6); DBG("Old IPv6.Address [%s] Received new IPv6.Address [%s]", old_ip6, value); -- 2.34.1