From 946cec7b65716f4781808f5ae3b3345f6d8b6c6d Mon Sep 17 00:00:00 2001 From: Juanjo Date: Tue, 14 Oct 2014 12:07:19 +0200 Subject: [PATCH] lib,src: fix spawnSync ignoring its 'env' option PR-URL: https://github.com/joyent/node/pull/8546 Reviewed-By: Colin Ihrig --- lib/child_process.js | 1 + src/spawn_sync.cc | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/child_process.js b/lib/child_process.js index c4345f9..e18b654 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -1262,6 +1262,7 @@ function spawnSync(/*file, args, options*/) { options.file = opts.file; options.args = opts.args; + options.envPairs = opts.envPairs; if (options.killSignal) options.killSignal = lookupSignal(options.killSignal); diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 59de8d4..f13a9e9 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -737,9 +737,9 @@ int SyncProcessRunner::ParseOptions(Local js_value) { r = CopyJsStringArray(js_env_pairs, &env_buffer_); if (r < 0) return r; - uv_process_options_.args = reinterpret_cast(env_buffer_); - } + uv_process_options_.env = reinterpret_cast(env_buffer_); + } Local js_uid = js_options->Get(env()->uid_string()); if (IsSet(js_uid)) { if (!CheckRange(js_uid)) -- 2.7.4