From 943b3048484b7e3cf04f4d51c23c82fcece2185d Mon Sep 17 00:00:00 2001 From: =?utf8?q?D=C3=A1vid=20Bolvansk=C3=BD?= Date: Sat, 9 Oct 2021 17:27:41 +0200 Subject: [PATCH] Fixed some errors detected by PVS Studio --- llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h | 2 +- llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp | 2 +- llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp | 2 +- llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp | 2 +- llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h index ddbb702..6b79579 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h @@ -96,7 +96,7 @@ public: return *this; } ExecutorAddr operator++(int) { return ExecutorAddr(Addr++); } - ExecutorAddr operator--(int) { return ExecutorAddr(Addr++); } + ExecutorAddr operator--(int) { return ExecutorAddr(Addr--); } ExecutorAddr &operator+=(const ExecutorAddrDiff Delta) { Addr += Delta.getValue(); diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp index 0ecb2d1..c74bec7 100644 --- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp +++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp @@ -6061,7 +6061,7 @@ LegalizerHelper::LegalizeResult LegalizerHelper::lowerRotate(MachineInstr &MI) { Register Src = MI.getOperand(1).getReg(); Register Amt = MI.getOperand(2).getReg(); LLT DstTy = MRI.getType(Dst); - LLT SrcTy = MRI.getType(Dst); + LLT SrcTy = MRI.getType(Src); LLT AmtTy = MRI.getType(Amt); unsigned EltSizeInBits = DstTy.getScalarSizeInBits(); diff --git a/llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp b/llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp index a03446b..c4e4791 100644 --- a/llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp +++ b/llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp @@ -332,7 +332,7 @@ bool DWARFFormValue::extractValue(const DWARFDataExtractor &Data, break; case DW_FORM_LLVM_addrx_offset: Value.uval = Data.getULEB128(OffsetPtr, &Err) << 32; - Value.uval = Data.getU32(OffsetPtr, &Err); + Value.uval |= Data.getU32(OffsetPtr, &Err); break; case DW_FORM_string: Value.cstr = Data.getCStr(OffsetPtr, &Err); diff --git a/llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp b/llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp index cb2b859..c1741dd 100644 --- a/llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp +++ b/llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp @@ -664,7 +664,7 @@ EHFrameEdgeFixer::readEncodedPointer(uint8_t PointerEncoding, EffectiveType = (PointerSize == 8) ? DW_EH_PE_udata8 : DW_EH_PE_udata4; JITTargetAddress Addr; - Edge::Kind PointerEdgeKind == Edge::Invalid; + Edge::Kind PointerEdgeKind = Edge::Invalid; switch (EffectiveType) { case DW_EH_PE_udata4: { uint32_t Val; diff --git a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp index 415269d..e5950d8 100644 --- a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp +++ b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp @@ -755,7 +755,7 @@ public: } bool operator==(const BDVState &Other) const { - return OriginalValue == OriginalValue && BaseValue == Other.BaseValue && + return OriginalValue == Other.OriginalValue && BaseValue == Other.BaseValue && Status == Other.Status; } -- 2.7.4