From 93d16ca647a95ffd929c81172dd3d49d770e9d85 Mon Sep 17 00:00:00 2001 From: devilhorns Date: Mon, 8 Aug 2011 20:35:48 +0000 Subject: [PATCH] Ecore_X: Add comment wrt Fixes extension version (for Tom). Remove unused code wrt invert regions. git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@62216 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- src/lib/ecore_x/xcb/ecore_xcb_xfixes.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/ecore_x/xcb/ecore_xcb_xfixes.c b/src/lib/ecore_x/xcb/ecore_xcb_xfixes.c index da17e1c..8f3004d 100644 --- a/src/lib/ecore_x/xcb/ecore_xcb_xfixes.c +++ b/src/lib/ecore_x/xcb/ecore_xcb_xfixes.c @@ -46,6 +46,12 @@ _ecore_xcb_xfixes_finalize(void) reply = xcb_xfixes_query_version_reply(_ecore_xcb_conn, cookie, NULL); if (reply) { + /* NB: XFixes Extension >= 3 needed for shape stuff. + * for now, I am removing this check so that it matches the + * xlib code closer. If the extension version ends up being + * that important, then re-enable this */ + + /* if (reply->major_version >= 3) */ _xfixes_avail = EINA_TRUE; free(reply); } @@ -366,23 +372,17 @@ ecore_x_region_invert(Ecore_X_Region dest, Ecore_X_Rectangle *bounds, Ecore_X_Re { #ifdef ECORE_XCB_XFIXES xcb_rectangle_t xrects; - int num = 0; #endif LOGFN(__FILE__, __LINE__, __FUNCTION__); #ifdef ECORE_XCB_XFIXES - while (bounds + num) - num++; - xrects.x = bounds->x; xrects.y = bounds->y; xrects.width = bounds->width; xrects.height = bounds->height; -// xrects = _ecore_xcb_rect_to_xcb(bounds, num); xcb_xfixes_invert_region(_ecore_xcb_conn, source, xrects, dest); -// free(xrects); #endif } -- 2.7.4