From 93c9110c980c9fc4bd72fb307c18f79afa0381e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 7 Nov 2020 17:12:57 +0100 Subject: [PATCH] [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin Use skipUnlessDarwin decorator for tests that are specific to Darwin, instead of skipIf... for all other platforms. This should make it clear that these tests are not supposed to work elsewhere. It will also make these tests stop repeatedly popping up while I look for tests that could be fixed on the platform in question. Differential Revision: https://reviews.llvm.org/D91003 --- .../data-formatter/setvaluefromcstring/TestSetValueFromCString.py | 4 +--- .../lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py | 4 +--- lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py | 4 +--- lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py | 3 +-- lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py | 4 +--- lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py | 4 +--- .../lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py | 5 +---- lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py | 4 +--- lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py | 4 +--- lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py | 3 +-- 10 files changed, 10 insertions(+), 29 deletions(-) diff --git a/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py b/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py index e08667f..f0152de 100644 --- a/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py +++ b/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py @@ -2,6 +2,4 @@ from lldbsuite.test import lldbinline from lldbsuite.test import decorators lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfNetBSD, decorators.skipIfWindows]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py b/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py index 562d9ae..f0152de 100644 --- a/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py +++ b/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py @@ -2,6 +2,4 @@ from lldbsuite.test import lldbinline from lldbsuite.test import decorators lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py b/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py index 562d9ae..f0152de 100644 --- a/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py +++ b/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py @@ -2,6 +2,4 @@ from lldbsuite.test import lldbinline from lldbsuite.test import decorators lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py b/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py index f1b3694..41719ec 100644 --- a/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py +++ b/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py @@ -3,6 +3,5 @@ from lldbsuite.test import decorators lldbinline.MakeInlineTest( __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD, + decorators.skipUnlessDarwin, decorators.skipIf(archs=["i386", "i686"])]) diff --git a/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py b/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py index 562d9ae..f0152de 100644 --- a/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py +++ b/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py @@ -2,6 +2,4 @@ from lldbsuite.test import lldbinline from lldbsuite.test import decorators lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py b/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py index 19832ae..4ba088e 100644 --- a/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py +++ b/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py @@ -2,6 +2,4 @@ from lldbsuite.test import decorators from lldbsuite.test import lldbinline lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py b/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py index cc6ac20b..9f2b5d6 100644 --- a/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py +++ b/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py @@ -9,10 +9,7 @@ class TestObjCXXHideRuntimeSupportValues(TestBase): mydir = TestBase.compute_mydir(__file__) - @skipIfFreeBSD - @skipIfLinux - @skipIfWindows - @skipIfNetBSD + @skipUnlessDarwin def test_hide_runtime_support_values(self): self.build() _, process, _, _ = lldbutil.run_to_source_breakpoint( diff --git a/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py b/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py index 19832ae..4ba088e 100644 --- a/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py +++ b/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py @@ -2,6 +2,4 @@ from lldbsuite.test import decorators from lldbsuite.test import lldbinline lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py b/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py index 19832ae..4ba088e 100644 --- a/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py +++ b/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py @@ -2,6 +2,4 @@ from lldbsuite.test import decorators from lldbsuite.test import lldbinline lldbinline.MakeInlineTest( - __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD]) + __file__, globals(), [decorators.skipUnlessDarwin]) diff --git a/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py b/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py index a06dd7a..59154e4 100644 --- a/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py +++ b/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py @@ -3,8 +3,7 @@ from lldbsuite.test import lldbinline lldbinline.MakeInlineTest( __file__, globals(), [ - decorators.skipIfFreeBSD, decorators.skipIfLinux, - decorators.skipIfWindows, decorators.skipIfNetBSD, + decorators.skipUnlessDarwin, decorators.expectedFailureAll( oslist=['macosx'], archs=['i386'], bugnumber='rdar://28656677')]) -- 2.7.4