From 93bb7fb04ccecb5d7d16f6b11108400975978199 Mon Sep 17 00:00:00 2001 From: Doyoun Kang Date: Thu, 29 Mar 2018 13:35:31 +0900 Subject: [PATCH] e_policy_visibility: remove _e_vis_ec_foreground_check function there was a bug that the black screen was shown when multi windows were destroyed. we checked activity window in _e_vis_ec_above_is_non_alpla_visible, so we can remove _e_vis_ec_foreground_check function. Change-Id: I03eac77f7a4d89a6989284c0a873cee6afe9aa58 --- src/bin/e_policy_visibility.c | 48 ------------------------------------------- 1 file changed, 48 deletions(-) diff --git a/src/bin/e_policy_visibility.c b/src/bin/e_policy_visibility.c index c57ce9a..6ef09f0 100644 --- a/src/bin/e_policy_visibility.c +++ b/src/bin/e_policy_visibility.c @@ -1509,26 +1509,6 @@ _e_vis_ec_job_exec(E_Client *ec, E_Vis_Job_Type type) } static Eina_Bool -_e_vis_ec_foreground_check(E_Client *ec, Eina_Bool with_transients) -{ - E_Client *child; - Eina_List *l; - - if (pol_vis->activity == ec) - return EINA_TRUE; - else if (with_transients) - { - EINA_LIST_FOREACH(ec->transients, l, child) - { - if (pol_vis->activity != child) continue; - return EINA_TRUE; - } - } - - return EINA_FALSE; -} - -static Eina_Bool _e_vis_ec_above_is_non_alpha_visible(E_Client *ec, Eina_Bool check_child) { E_Client *above; @@ -1825,13 +1805,6 @@ _e_vis_intercept_hide(void *data EINA_UNUSED, E_Client *ec) return EINA_FALSE; } - /* find activity client among the clients to be lower */ - if (!_e_vis_ec_foreground_check(ec, !!e_config->transient.raise)) - { - VS_INF(ec, "NO activity clients"); - return EINA_TRUE; - } - if (_e_vis_ec_above_is_non_alpha_visible(ec, EINA_FALSE)) { VS_DBG(ec, "Obscured by above window."); @@ -1972,13 +1945,6 @@ e_policy_visibility_client_lower(E_Client *ec) /* if vc has job grab, release them */ _e_vis_client_grab_cancel(vc); - /* find activity client among the clients to be lower */ - if (!_e_vis_ec_foreground_check(ec, !!e_config->transient.lower)) - { - VS_INF(ec, "NO activity clients"); - return EINA_FALSE; - } - if (_e_vis_ec_above_is_non_alpha_visible(ec, EINA_TRUE)) { VS_DBG(ec, "Obscured by above window."); @@ -2009,13 +1975,6 @@ e_policy_visibility_client_iconify(E_Client *ec) if (ec->iconic) return EINA_FALSE; - /* find activity client among the clients to be lower */ - if (!_e_vis_ec_foreground_check(ec, !!e_config->transient.iconify)) - { - VS_INF(ec, "NO activity clients"); - return EINA_FALSE; - } - if (_e_vis_ec_above_is_non_alpha_visible(ec, EINA_TRUE)) { VS_DBG(ec, "Obscured by above window."); @@ -2115,13 +2074,6 @@ e_policy_visibility_client_layer_lower(E_Client *ec, E_Layer layer) /* if vc has job grab, release them */ _e_vis_client_grab_cancel(vc); - /* find activity client among the clients to be lower */ - if (!_e_vis_ec_foreground_check(ec, !!e_config->transient.lower)) - { - VS_INF(ec, "NO activity clients"); - return EINA_FALSE; - } - if (_e_vis_ec_above_is_non_alpha_visible(ec, EINA_TRUE)) { VS_DBG(ec, "Obscured by above window."); -- 2.7.4