From 933479869291cf779499ba2cd2cf9faf9c1a45b3 Mon Sep 17 00:00:00 2001 From: bryce Date: Sun, 26 Oct 2003 02:28:45 +0000 Subject: [PATCH] * java/lang/reflect/AccessibleObject.java (secureSetAccessible): Don't check for AccessibleObject. Update javadocs. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@72943 138bc75d-0d04-0410-961f-82ee72b054a4 --- libjava/ChangeLog | 5 +++ libjava/java/lang/reflect/AccessibleObject.java | 45 +++++++------------------ 2 files changed, 17 insertions(+), 33 deletions(-) diff --git a/libjava/ChangeLog b/libjava/ChangeLog index 54a900b..8d14a77 100644 --- a/libjava/ChangeLog +++ b/libjava/ChangeLog @@ -1,5 +1,10 @@ 2003-10-26 Bryce McKinlay + * java/lang/reflect/AccessibleObject.java (secureSetAccessible): + Don't check for AccessibleObject. Update javadocs. + +2003-10-26 Bryce McKinlay + * java/lang/reflect/Constructor.java (toString): Avoid extra whitespace on constructor with no modifiers. * java/lang/reflect/natConstructor.java (newInstance): Look up diff --git a/libjava/java/lang/reflect/AccessibleObject.java b/libjava/java/lang/reflect/AccessibleObject.java index 456f65a..4fb89bb 100644 --- a/libjava/java/lang/reflect/AccessibleObject.java +++ b/libjava/java/lang/reflect/AccessibleObject.java @@ -59,8 +59,7 @@ public class AccessibleObject { /** * True if this object is marked accessible, which means the reflected - * object bypasses normal security checks. NOTEDon't try messing - * with this by reflection. You'll mess yourself up. + * object bypasses normal security checks. */ // default visibility for use by inherited classes boolean flag = false; @@ -88,19 +87,11 @@ public class AccessibleObject * security check. If a security manager exists, it is checked for * ReflectPermission("suppressAccessChecks").

* - * If flag is true, and the initial security check succeeds, - * this can still fail if a forbidden object is encountered, leaving the - * array half-modified. At the moment, the forbidden members are:
- *

    - *
  • Any Constructor for java.lang.Class
    • - *
  • Any AccessibleObject for java.lang.reflect.AccessibleObject - * (this is not specified by Sun, but it closes a big security hole - * where you can use reflection to bypass the security checks that - * reflection is supposed to provide)
    • - *
- * (Sun has not specified others, but good candidates might include - * ClassLoader, String, and such. However, the more checks we do, the - * slower this method gets). + * It is forbidden to set the accessibility flag to true on any constructor + * for java.lang.Class. This will result in a SecurityException. If the + * SecurityException is thrown for any of the passed AccessibleObjects, + * the accessibility flag will be set on AccessibleObjects in the array prior + * to the one which resulted in the exception. * * @param array the array of accessible objects * @param flag the desired state of accessibility, true to bypass security @@ -121,19 +112,8 @@ public class AccessibleObject * manager exists, it is checked for * ReflectPermission("suppressAccessChecks").

* - * If flag is true, and the initial security check succeeds, - * this will still fail for a forbidden object. At the moment, the - * forbidden members are:
- *

    - *
  • Any Constructor for java.lang.Class
    • - *
  • Any AccessibleObject for java.lang.reflect.AccessibleObject - * (this is not specified by Sun, but it closes a big security hole - * where you can use reflection to bypass the security checks that - * reflection is supposed to provide)
    • - *
- * (Sun has not specified others, but good candidates might include - * ClassLoader, String, and such. However, the more checks we do, the - * slower this method gets). + * It is forbidden to set the accessibility flag to true on any constructor for + * java.lang.Class. This will result in a SecurityException. * * @param flag the desired state of accessibility, true to bypass security * @throws NullPointerException if array is null @@ -165,15 +145,14 @@ public class AccessibleObject * after calling checkPermission. * * @param flag the desired status - * @throws SecurityException if flag is true and this is one of the - * forbidden members mentioned in {@link setAccessible(boolean)}. + * @throws SecurityException if flag is true and this is a constructor + * for java.lang.Class. */ private final void secureSetAccessible(boolean flag) { if (flag && - ((this instanceof Constructor - && ((Constructor) this).getDeclaringClass() == Class.class) - || ((Member) this).getDeclaringClass() == AccessibleObject.class)) + (this instanceof Constructor + && ((Constructor) this).getDeclaringClass() == Class.class)) throw new SecurityException("Cannot make object accessible: " + this); this.flag = flag; } -- 2.7.4